Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Paging 3 #3396

Merged
merged 19 commits into from Jul 28, 2022
Merged

Fix Paging 3 #3396

merged 19 commits into from Jul 28, 2022

Commits on Jul 28, 2022

  1. Copy-paste Room LimitOffsetPagingSource.kt and associated files 

    https://github.com/androidx/androidx/tree/androidx-main/room/room-paging/src/main/java/androidx/room/paging
    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    7299b74 View commit details
    Browse the repository at this point in the history

  2. Don't limit to library scope

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    89e18bd View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary constructor

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    6c9b913 View commit details
    Browse the repository at this point in the history

  4. Remove unused argument

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    4efa346 View commit details
    Browse the repository at this point in the history

  5. Remove usages of getQueryDispatcher

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    31b3f73 View commit details
    Browse the repository at this point in the history

  6. Remove usages of androidx.room.withTransaction

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    49eda6b View commit details
    Browse the repository at this point in the history

  7. Remove usage of app.cash.sqldelight.paging3.util.queryItemCount

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    e1d997f View commit details
    Browse the repository at this point in the history

  8. Rename Value to RowType to align with SQLDelight

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    28ca396 View commit details
    Browse the repository at this point in the history

  9. Pass in a QueryProvider and then remove all fluff

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    4ea18c0 View commit details
    Browse the repository at this point in the history

  10. Put queryDatabase within LimitOffsetPagingSource

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    5bf920c View commit details
    Browse the repository at this point in the history

  11. Use QueryPagingSource as the invalidater

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    c9e4b24 View commit details
    Browse the repository at this point in the history

  12. Simplify

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    ac9219a View commit details
    Browse the repository at this point in the history

  13. Copy-paste tests from AndroidX

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    f24f92b View commit details
    Browse the repository at this point in the history

  14. Fix test compilation

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    562c092 View commit details
    Browse the repository at this point in the history

  15. Spotless

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    2683237 View commit details
    Browse the repository at this point in the history

  16. Update extensions/android-paging3/src/test/java/app/cash/sqldelight/p… 

    …aging3/WithPagingDataDiffer.kt

Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
    @veyndan @vanniktech
    veyndan and vanniktech committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    9bc2b43 View commit details
    Browse the repository at this point in the history

  17. Update extensions/android-paging3/src/test/java/app/cash/sqldelight/p… 

    …aging3/WithPagingDataDiffer.kt

Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
    @veyndan @vanniktech
    veyndan and vanniktech committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    03744d0 View commit details
    Browse the repository at this point in the history

  18. Apply suggestions from code review 

    Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
    @veyndan @vanniktech
    veyndan and vanniktech committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    f3ce22b View commit details
    Browse the repository at this point in the history

  19. Make the artifact a JVM one again

    @veyndan
    veyndan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    71501d2 View commit details
    Browse the repository at this point in the history