Don't throw exception on empty data in AndroidX Paging3 extension #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veyndan
commented
Mar 29, 2021
...paging3/src/test/java/com/squareup/sqldelight/android/paging3/OffsetQueryPagingSourceTest.kt
Show resolved
Hide resolved
kevincianfarini
approved these changes
Mar 29, 2021
...paging3/src/test/java/com/squareup/sqldelight/android/paging3/OffsetQueryPagingSourceTest.kt
Show resolved
Hide resolved
vanniktech
reviewed
Mar 13, 2022
| @@ -37,7 +37,7 @@ internal class OffsetQueryPagingSource<RowType : Any>( | |||
| val key = params.key ?: 0L | |||
| transacter.transactionWithResult { | |||
| val count = countQuery.executeAsOne() | |||
| if (key >= count) throw IndexOutOfBoundsException() | |||
There was a problem hiding this comment.
I have a filtering applied (show only unread items). When I mark an item as read obviously count is smaller than key and I'd expect that item to disappear. Paging2 source handled this perfectly well, what's the reason for throwing here @kevincianfarini ? Does paging3 not support items being removed?
There was a problem hiding this comment.
How are you marking the item as read? If you're mutating a row in the database, I would expect this paging source to get invalidated.
There was a problem hiding this comment.
Yes I am mutating a row in the database. I found a way to make this work in #2913 for me locally (there's some more information)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just trying out the new AndroidX Paging3 extension and I'm getting an
IndexOutOfBoundsExceptionwhen my table is empty (i.e.,countQuery.executeAsOne() == 0). I'm new to the Paging3 library, but I'd assume that the table being empty shouldn't throw an exception.