Bump AGP to 8.1.0 #236
Bump AGP to 8.1.0 #236
Conversation
build.gradle
Outdated
| @@ -60,6 +60,23 @@ tasks.named("test") { | |||
| } | |||
| exceptionFormat "full" | |||
| } | |||
| // AGP 8+ requires JVM 17+. | |||
| javaLauncher = javaToolchains.launcherFor { | |||
| languageVersion = JavaLanguageVersion.of(17) | |||
There was a problem hiding this comment.
Could you please elaborate why?
There was a problem hiding this comment.
Gradle will reuse the installed JDK first, https://docs.gradle.org/current/userguide/toolchains.html#sec:auto_detection
There was a problem hiding this comment.
The used JDK to execute Gradle is independent of the JDK used to run the compiler or tests.
To actually run Gradle (this project), you need a JVM, depending on your setup either JAVA_HOME, your project JDK (IntelliJ) or the the specified JDK in GitHub workflow (using setup-java setting JAVA_HOME).
The used Gradle version + Gradle plugins by licensee requires JVM 11.
Now licensee specified JVM 11 for compiling, without any constraints. The same version is used on CI, so Gradle reuse the JDK.
The tests requires JDK 17 (due to AGP 8+), which is specified in the test task using the javaLauncher. So Gradle needs to get a JDK 17.
The auto-detection you mention is about the default paths Gradle looks for JDK 17. The hostedtoolchain paths on GitHub CI isn't used today by Gradle (gradle/gradle#14903), so we use the foojay resolver plugin. Without this plugin, Gradle is unable to download a request JDK.
There was a problem hiding this comment.
TIL, I always believe Gradle honored the output path of setup-java, thanks for your sharing.
There was a problem hiding this comment.
Unfortunately, it doesn't, but this will finally be fixed by the grade-build-action, according to the planned 2.8.0 release: gradle/gradle-build-action#561
|
BTW Gradle 8.3 is out, so we can use JVM 20 too, after updating. |
JVM 20 isn't supported with the precompiled included build used by the tests, because Gradle 8.2.1 uses Kotlin 1.8.22. I could switch from Kotlin to Groovy, or we just use JVM 17 until Gradle 8.3 is out.