Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright headers #900

Merged

Conversation

prashantrewar
Copy link
Contributor

Fixes #896

Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prashantrewar We also need to update the code-header-template.txt with the same change. This will make the linter pass.
(kapp PR for reference)

@praveenrewar
Copy link
Member

praveenrewar commented Mar 28, 2024

My bad, I just noticed that you had already made that change, the linter just needed a rerun for some reason.

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@praveenrewar praveenrewar merged commit 4b40e30 into carvel-dev:develop Mar 28, 2024
5 checks passed
@prashantrewar prashantrewar deleted the update-copyright-headers branch March 28, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update copyright headers
2 participants