Fix typo #814
Merged
Fix typo #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch on the typos - LGTM |
jtigger
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
@hezhizhen thank you very much for catching these typos!
Every little bit counts. Typos can be distracting to readers; removing them ticks up readability. 🙏
jtigger
suggested changes
Apr 19, 2023
There was a problem hiding this comment.
Oops!
I missed the linter's complaint about wanting a comment on an exported method.
I've added the suggestion, @hezhizhen. Please accept the suggestion or adjust to your preference. 👍
edit: nvm, I see the PR is editable by maintainers; will fix that for ya. 👍
After fixing typo, comment became required by our linter.
jtigger
approved these changes
Apr 19, 2023
Thanks. |
github-actions
bot
added
the
carvel triage
kbudde
pushed a commit
to mykso/myks
that referenced
this pull request
Dec 25, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [carvel-dev/ytt](https://togithub.com/carvel-dev/ytt) | minor | `0.45.0` -> `v0.46.3` | --- ### Release Notes <details> <summary>carvel-dev/ytt (carvel-dev/ytt)</summary> ### [`v0.46.3`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.46.3) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.46.2...v0.46.3) #### What's Changed - Bump go version to 1.21.5 [@​rcmadhankumar](https://togithub.com/rcmadhankumar) in [carvel-dev/ytt#886 **Full Changelog**: carvel-dev/ytt@v0.46.1...v0.46.3 ### 📂 Files Checksum 15058f993f10524473d1f612a2ff344a6f51ce28d291228f650f605a226f4e97 ./ytt-windows-arm64.exe 271b145c7eb20f1ce424eab22b557662b2f7b1bd008bc2f1833ab56a567f05ef ./ytt-windows-amd64.exe 2b4ca5365c343bb1e903e8e845d9750b5d2776b3a99483912f27da6e95c480c0 ./ytt-linux-amd64 46e672afcf2c2c09c415f52f472d6dcc648324fd5acf7c83c6b6017223dc4042 ./ytt-darwin-amd64 5372597c7165cb09657c7b9cfb5da1e58673940cf0ebbd4ecf8040e9ab9eb9e7 ./ytt-linux-arm64 d42295bbe137bdc08471ce61857ee1ee20761cd58a5a1827fde9c622e6b0e151 ./ytt-darwin-arm64 ### [`v0.46.2`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.46.2) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.46.0...v0.46.2) #### What's Changed - Bump go version to 1.21.3 by [@​sethiyash](https://togithub.com/sethiyash) in [carvel-dev/ytt#879 **Full Changelog**: carvel-dev/ytt@v0.46.0...v0.46.2 ### 📂 Files Checksum 027a12c62b3233a409d1eeabe689be9ff97de312dd6f18063000cdfa65b41032 ./ytt-windows-amd64.exe 71f9a7d83f51fd3a6096720d2f7f10184c62030e090fdb9daad62e1de0627aad ./ytt-windows-arm64.exe a97bae2e7a069032402d66b302c073c595a2badf2c3ffc6eec86427eec21619b ./ytt-darwin-arm64 adeb18daa5fa088123ffbd9e32e3252aaf32810ec70e5e1b5a186f7bffc8c1f5 ./ytt-darwin-amd64 ae9bc66a55756eed60db86f8c0f8c55704b3ab846513ad4502111c2a8673ecac ./ytt-linux-amd64 e43a524db8a0c69a54bc56132ac0cf8d55a049c48f63a9047dd6984dc89a940e ./ytt-linux-arm64 ### [`v0.46.0`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.46.0) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.9...v0.46.0) ### ✨ What's new - Bumping go version to 1.21.1 by [@​sethiyash](https://togithub.com/sethiyash) in [carvel-dev/ytt#871 ### 📂 Files Checksum 0c025f1210875f185a867e6cb3fd4770627f13ce64d69b6092de713464395ddb ./ytt-darwin-arm64 348cb34965b64c07fd5118e69efd9a4fae7e22f57db4e91e2d9903c1ad19f041 ./ytt-linux-amd64 4738b733718717ceffe71f61053b24f059e85af8a00061a7f169a9b2342ca800 ./ytt-windows-arm64.exe 59b9c97fd7a30a9fa7c453e774078212d2751c247b6c99c5a8ff5bae5fc0703f ./ytt-windows-amd64.exe 9552c863452622386b9e9fcab0eb0533b6e8c77bc3f5c753967d40232b2a1721 ./ytt-linux-arm64 a2ca42f8178ba2849076b580177c5c12769e17f01a61ab50b106367728004692 ./ytt-darwin-amd64 ### [`v0.45.9`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.45.9) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.8...v0.45.9) #### What's Changed - Bump go version to 1.20.12 by [@​rcmadhankumar](https://togithub.com/rcmadhankumar) in [carvel-dev/ytt#885 **Full Changelog**: carvel-dev/ytt@v0.45.8...v0.45.9 ### 📂 Files Checksum 32a5592c4fbc6bceae6c8ee856914bff5c284114698cfc1fed62ec900980affd ./ytt-linux-amd64 3fc8566120b4f7e48c06a5e0c3212aa5ac54d876ad9f40d2f413ffe6c77bfad6 ./ytt-darwin-amd64 6806eb2834da5cdb1ee2213ef04d684917943ab1c61172106500e0830d97be69 ./ytt-linux-arm64 792b98ecab2ceb7851970759d36a0890d55372b43d1225eb662730395c80974e ./ytt-windows-amd64.exe 798b0145a18f0f669f3c6dbd22051a565f380beeb19f7b11d6049e066800c080 ./ytt-windows-arm64.exe a26c55791a9c082878acbbb9c542bd6a915c02ba3f58c2c66f8c3d4bec124802 ./ytt-darwin-arm64 ### [`v0.45.8`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.45.8) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.7...v0.45.8) ### ✨ What's new - Bump go version to 1.20.11 in v0.45.x line by [@​sethiyash](https://togithub.com/sethiyash) in [carvel-dev/ytt#880 **Full Changelog**: carvel-dev/ytt@v0.45.7...v0.45.8 ### 📂 Files Checksum 043b27cecb6b1511caacacaa0f4f5350c424207f176e54b659a6fbf7d1da48f3 ./ytt-windows-arm64.exe 2f0aa3127e9aa3e588b98169358b488dbe82d04c2a24b63f6faa09ed797e312b ./ytt-darwin-amd64 3f05260d6ca6ee9268921c6b58b828c4e58ec47ee7014bfa8c342a40dcb8041d ./ytt-darwin-arm64 506b3b9d0ab3ba0f9ed3fc47e5afae33b8624fd928075c62de8ac2517f52c069 ./ytt-linux-arm64 ba308a20b7711c2fd769baa3470f62788ec4356686557076ac7b857160c3cc69 ./ytt-linux-amd64 eaa454d99805f1b5714de882b5bb507756be46834305689679595a6ce9f5f130 ./ytt-windows-amd64.exe ### [`v0.45.7`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.45.7) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.6...v0.45.7) #### What's Changed - Bump Go to 1.20.10 by [@​sethiyash](https://togithub.com/sethiyash) in [carvel-dev/ytt#875 **Full Changelog**: carvel-dev/ytt@v0.45.6...v0.45.7 ### 📂 Files Checksum 2771586197a0be8b5df9270f9ca2f05fe01b4c6fe01eb56398c642c870c08b0b ./ytt-windows-arm64.exe 9df647c8b25918bef0b189d091d84fc40e506c24a80e9af2f28070ad4166b131 ./ytt-windows-amd64.exe b704d22ae50785618bce00afaad3c4b63c24e211fbca17d02361747cf047d7de ./ytt-darwin-arm64 bb45a5a192f409d11221db930d4420603b632ff09bf1621202c755b104f73f88 ./ytt-darwin-amd64 d8114c573a04c67aab3d69c037adf87444f082a5872331ebb361c4a4a8cb6ab3 ./ytt-linux-amd64 efd7865f3cb3cf9e9b420cfc10fbe01cd9166103a6ec778dd66bc5f85b85621e ./ytt-linux-arm64 ### [`v0.45.6`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.45.6) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.5...v0.45.6) ✨ What's new - add cii badge to readme.md by [@​microwavables](https://togithub.com/microwavables) in [carvel-dev/ytt#867 Full Changelog: carvel-dev/ytt@v0.45.4...v0.45.6 📂 Files Checksum 1ff2102dc9dada482060de0504698683e5d8b8721441841795136b92da68e664 ./ytt-windows-arm64.exe 2b32add6ceb66d0abf41663316810b2175c4df59286a6c0ca5b39582a689621f ./ytt-darwin-amd64 4be1ecdcad3cd43066692944b13ca6f99f03043a1ca78a4c4590011400a61e32 ./ytt-linux-amd64 a4bfc0e27ccd5d2c72fade9cb1a446d8a6704774daca9dbd373c4f5cd0e7a204 ./ytt-linux-arm64 c72b619852d9e3c1cfd870b13df2a142593df3ac061cfa1dd7451dcd036d46f8 ./ytt-windows-amd64.exe cc527918325b4876b00eca8bda71d2e1e7f2cc83de530be328994b89f3586dc2 ./ytt-darwin-arm64 ### [`v0.45.5`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.45.5) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.4...v0.45.5) 🔴 Please disregard this version because it bumps go to 1.21, which might cause problems if you are importing ytt has a library. *** ### ✨ What's new - add cii badge to readme.md by [@​microwavables](https://togithub.com/microwavables) in [carvel-dev/ytt#867 - Bumping go version to 1.21.1 by [@​sethiyash](https://togithub.com/sethiyash) in [carvel-dev/ytt#871 **Full Changelog**: carvel-dev/ytt@v0.45.4...v0.45.5 ### 📂 Files Checksum 01d2baa62be2ef8cff869139fb44acdde341d52f4201fc9c6c1fe878190bee58 ./ytt-darwin-arm64 5d3d9929f012895579dc3791ae45d4a3bc07c4ef59593113e3e9b9851f35e0cc ./ytt-windows-amd64.exe 811b026bfe5938b89dd0899303ea54ad3eb3b31c1cc698112c8d99a2abbe4fc4 ./ytt-windows-arm64.exe 9817dd189776026fe6f58b0f5e22f8477a94645b6be739062fc632626b946c2b ./ytt-darwin-amd64 c98d4baf2174bb1b9deb406405b16bbdf5c0df6ef4e1ebe2f782d45b37dfd647 ./ytt-linux-amd64 d6d149f7a0ed9070a97d70c909ec741a705f2f11a4dda2df6eff05262a7f218b ./ytt-linux-arm64 ### [`v0.45.4`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.45.4) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.3...v0.45.4) ### ✨ What's new - chore: slice append replace loop by [@​testwill](https://togithub.com/testwill) in [carvel-dev/ytt#860 - chore: remove refs to deprecated io/ioutil by [@​testwill](https://togithub.com/testwill) in [carvel-dev/ytt#859 - chore: unnecessary use of fmt.Sprintf by [@​testwill](https://togithub.com/testwill) in [carvel-dev/ytt#862 - chore: pkg imported more than once by [@​testwill](https://togithub.com/testwill) in [carvel-dev/ytt#861 - Bumping go version to 1.20.7 by [@​sethiyash](https://togithub.com/sethiyash) in [carvel-dev/ytt#863 ### 🔈 Callouts Thanks to - [@​testwill](https://togithub.com/testwill) made their first contribution in [carvel-dev/ytt#859 **Full Changelog**: carvel-dev/ytt@v0.45.3...v0.45.4 ### 📂 Files Checksum 2ab67119b95db782fa4db3b1921b4c67f0978920e048facca11055fe07ac394e ./ytt-windows-arm64.exe 2b6d173dec1b6087e22690386474786fd9a2232c4479d8975cc98ae8160eea76 ./ytt-darwin-amd64 3e6f092bfe7a121d15126a0de6503797818c6b6745fbc97213f519d35fab08f9 ./ytt-darwin-arm64 9bf62175c7cc0b54f9731a5b87ee40250f0457b1fce1b0b36019c2f8d96db8f8 ./ytt-linux-amd64 cbfc85f11ffd8e61d63accf799b8997caaebe46ee046290cc1c4d05ed1ab145b ./ytt-linux-arm64 f9163ed615d070385bd4c26415956d4897d00f98cef7cb92f0c3922d592dc2e5 ./ytt-windows-amd64.exe ### [`v0.45.3`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.45.3) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.2...v0.45.3) ### ✨ What's new - Bumping go version to 1.20.5 by [@​sethiyash](https://togithub.com/sethiyash) [#​848](https://togithub.com/carvel-dev/ytt/issues/848) **Full Changelog**: carvel-dev/ytt@v0.45.2...v0.45.3 ### 📂 Files Checksum 61114a5d245e0ca1deb158f2646f754d90e30e44d3381f8ab2efa491a0541c99 ./ytt-darwin-arm64 9c9ed87d65eb243ad9b65f13cebd1d47c70c46ea1e416772284c12c92707d8be ./ytt-windows-amd64.exe a21a6e45f92ae71eae95e771bb8da6e939593c6679d3da36c4ae2204afdcce5f ./ytt-darwin-amd64 a6729fb8514f10ab58f9ed3b50cd90ef79bf16d1cb29173baa84e1af0bc5ad4f ./ytt-linux-amd64 aca1e44577bdf2f08acb56d035dc654ad6cdfac0d148a781f34637eefa852846 ./ytt-windows-arm64.exe b0068b729e6787d0e6093ceb5678f5882d1ea2d56d75895e91f2082f64e588c5 ./ytt-linux-arm64 ### [`v0.45.2`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.45.2) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.1...v0.45.2) ### ✨ What's new - Fix typo by [@​hezhizhen](https://togithub.com/hezhizhen) in [carvel-dev/ytt#814 - Bumping Go version to 1.20.4 by [@​sethiyash](https://togithub.com/sethiyash) in [carvel-dev/ytt#840 ### 🔈 Callouts - [@​hezhizhen](https://togithub.com/hezhizhen) made their first contribution in [carvel-dev/ytt#814 **Full Changelog**: carvel-dev/ytt@v0.45.1...v0.45.2 ### 📂 Files Checksum 11c357a59cee76dc06a0ad8e4ad081fd0fe0b9923ca7458967692de98cca43c7 ./ytt-linux-arm64 2cf05b68d3b8aa508a8c1b1739364ee585b08338a03aa93fe6807c08871ba289 ./ytt-darwin-amd64 5ec2e7d74d0d2b850f807cec53e5110e08ab7f4b2e58efe48e2e25b062a1afaa ./ytt-windows-amd64.exe 9ba6097a9c587a3f6c18548427e6db2302fc1adfd3c34703f10f2bc133e09a7a ./ytt-windows-arm64.exe c909d88845ce55430a91a1cf9db5e3f14ffa8ce53d6ecb42e7ff3acf56a2037f ./ytt-linux-amd64 dd1cf5f1b57a206b740cbe3f855daa840c07df69c87d859b575a34a26a4aa19e ./ytt-darwin-arm64 ### [`v0.45.1`](https://togithub.com/carvel-dev/ytt/releases/tag/v0.45.1) [Compare Source](https://togithub.com/carvel-dev/ytt/compare/v0.45.0...v0.45.1) ### ✨ What's new - Bump golang to 1.20.3 and fix golint issues by [@​sethiyash](https://togithub.com/sethiyash) in [carvel-dev/ytt#832 **Full Changelog**: carvel-dev/ytt@v0.45.0...v0.45.1 ### 📂 Files Checksum 01606d885cdbce02340faadc29a83b5415280bc610e7cff3f639385d8f504aea ./ytt-linux-amd64 0d06d9a822b589234dc000111e993e244705e117d20c4c74435fc642c0f2d459 ./ytt-windows-arm64.exe 0f151a7191ade2269fd67932e35547c75b89948a96a0f33615765041993b55a2 ./ytt-darwin-arm64 1c9a0167b4d0d92e112fc817273c7e168f8c8b0ef9a4040bd7695add1d0c7df6 ./ytt-darwin-amd64 50cee1125897b67aa51d02c5ef13bf9632ad042251fec7fc7ae51376a90fe5da ./ytt-windows-amd64.exe e5112e7c69c4e664d245a5482fad95f07b49b04c77c7b2c86f1eab86d294817a ./ytt-linux-arm64 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mykso/myks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.