Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add Custom Metrics Example via Kube-state-metrics #1282

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yashvardhanmishra
Copy link

What this PR does / why we need it:

This PR adds a example in the README file to demonstrate how to extend kapp-controller's metrics using kube-state-metrics CustomResourceStateMetrics

Which issue(s) this PR fixes:

Fixes #1159

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@neil-hickey
Copy link
Contributor

hey @yashvardhanmishra ,thanks for this! It's great, happy to merge. Looks like our bot needs you to sign your commit. Typically done via git commit -s, this is a required for CNCF projects, so let us know if you need any help in doing that!

Copy link
Contributor

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when commit is signed, happy to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Doc] Add example of Custom Metrics via Kube-state-metrics CustomResourceStateMetrics
3 participants