Subpath doc update #1195
Open
Subpath doc update #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Berche <guillaume.berche@orange.com>
* updating repo url to generic name as TCE is getting deprecated and updated package name to a generic name as well * updated namespace flag to package available cmd * removed -n flag from cmd added in example * reverted unwanted change Co-authored-by: kumari tanushree <ktanushree@vmware.com> Signed-off-by: Guillaume Berche <guillaume.berche@orange.com>
To remove ambiguity that the root would remain the same but only the subpath is preserved (i.e users could incorrectly think absolute paths within the repo would be preserved) See related code: https://github.com/carvel-dev/kapp-controller/blob/ad24bdc3e41219b176f88280a469e9fd21979339/pkg/fetch/vendir.go#L157-L157 Signed-off-by: Guillaume Berche <guillaume.berche@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: