Add max-depth flag to describe #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Per Hermansson <perher@netinsight.net>
netiperher
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
joaopapereira
requested changes
May 25, 2023
| @@ -98,7 +99,7 @@ func DescribeWithRegistryAndSignatureFetcher(bundleImage string, opts DescribeOp | |||
| return Description{}, fmt.Errorf("Only bundles can be described, and %s is not a bundle", bundleImage) | |||
| } | |||
|
|
|||
| allBundles, err := newBundle.FetchAllImagesRefs(opts.Concurrency, opts.Logger, sigFetcher) | |||
| allBundles, err := newBundle.FetchAllImagesRefs(opts.Concurrency, opts.MaxDepth, opts.Logger, sigFetcher) | |||
There was a problem hiding this comment.
Before we call FetchAllImagesRefs do you mind checking that the depth is >= 0? Just to ensure people do not try to get a negative number in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bundle contains a large set of nested bundles the describe command on the root bundle can take a long time.
This change introduces a
--max-depthflag to the describe command in order to limit the depth of recursion that is performed on the bundle. This is similar to the--no-recursionflag discussed in #204 .