Allow copy and describe of SBOM, attestations and signatures from cosign #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppforlife
reviewed
Jun 3, 2022
Comment on lines
103
to
115
| wg.Go(func() error { | ||
| artifactRef, err := s.retrieveArtifact(ref, throttle, SBOM) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if artifactRef == nil { | ||
| return nil | ||
| } | ||
| lock.Lock() | ||
| artifacts = append(artifacts, *artifactRef) | ||
| lock.Unlock() | ||
| return nil | ||
| }) |
There was a problem hiding this comment.
should we do next three sections in a loop []x{SBOM, Attestation, Signature}?
Rename flags to `cosign-artifacts` Change logic to allow the retrieval of SBOM and attestations as well as signatures for these images Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
force-pushed
the
cosign-artifacts
branch
from
60d0318
to
b60b9f3
Compare
joaopapereira
had a problem deploying
to
TanzuNet Registry Dev e2e
GitHub Actions
Failure
joaopapereira
temporarily deployed
to
GCR e2e
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename flags to
cosign-artifactsChange logic to allow the retrieval of SBOM and attestations as well as
signatures for these images
Fixes #269