Update Callback Documentation #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshibuya
reviewed
Jan 7, 2024
README.md
Outdated
| def log_removal | ||
| ::Rails.logger.info(format('Deleting file on S3: %s', @file)) | ||
| def log_removal(file) | ||
| ::Rails.logger.info(format('Deleting file on S3: %s', file)) |
There was a problem hiding this comment.
Please clarify what sort of a problem this is trying to address.
There was a problem hiding this comment.
@mshibuya
Sorry for not explaining.
The reason I changed the argument was because an ArgmentError occurred.
F, [2024-01-07T18:02:54.020568 #88960] FATAL -- :
ArgumentError (wrong number of arguments (given 1, expected 0)):
app/uploaders/XXX_uploader.rb:14:in `log_retrieve_from_store'
carrierwave (2.2.2) lib/carrierwave/uploader/callbacks.rb:16:in `block in with_callbacks'
carrierwave (2.2.2) lib/carrierwave/uploader/callbacks.rb:16:in `each'
carrierwave (2.2.2) lib/carrierwave/uploader/callbacks.rb:16:in `with_callbacks'
carrierwave (2.2.2) lib/carrierwave/uploader/store.rb:86:in `retrieve_from_store!'
carrierwave (2.2.2) lib/carrierwave/uploader/versions.rb:327:in `block in retrieve_versions_from_store!'
carrierwave (2.2.2) lib/carrierwave/uploader/versions.rb:327:in `each'
carrierwave (2.2.2) lib/carrierwave/uploader/versions.rb:327:in `retrieve_versions_from_store!'
carrierwave (2.2.2) lib/carrierwave/uploader/callbacks.rb:16:in `block in with_callbacks'
carrierwave (2.2.2) lib/carrierwave/uploader/callbacks.rb:16:in `each'
There was a problem hiding this comment.
The retrieve_from_store callback takes an argument,
carrierwave/lib/carrierwave/uploader/store.rb
Line 104 in 20c6d75
but the remove callback doesn't.
So this change will break, right?
There was a problem hiding this comment.
Thanks to your explanation, I have completely understood...
I have canceled it 🙇
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.