Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated configuration from README #2661

Merged

Conversation

cou929
Copy link
Contributor

@cou929 cou929 commented Mar 25, 2023

I've set up a project with carrierwave and fog-google following the README. And got a deprecation warning message.

DEPRECATION WARNING: #fog_provider is deprecated and has no effect (called from block in <main> at /Users/cou929/Desktop/ws-fog/test_carrierwave/config/initializers/carrierwave.rb:4)
# config/initializers/carrierwave.rb

CarrierWave.configure do |config|
    config.fog_provider = 'fog/google'
    config.fog_credentials = {
        provider:               'Google',
        google_project:         'my-project',
        google_json_key_string: 'xxxxxx'
        # or use google_json_key_location if using an actual file
    }
    config.fog_directory = 'google_cloud_storage_bucket_name'
end

It seems that the config.fog_provider was already deprecated but came back to README after that.

@mshibuya mshibuya merged commit 6c4df8c into carrierwaveuploader:master Mar 26, 2023
11 of 13 checks passed
@mshibuya
Copy link
Member

Good catch, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants