Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Manage transaction rollback" #2545

Closed
wants to merge 1 commit into from
Closed

Revert "Manage transaction rollback" #2545

wants to merge 1 commit into from

Commits on Mar 17, 2021

  1. Revert "Manage transaction rollback" 

    This commit attempts to fix leftover files in failed transactions, but
in the process introduces three problems:

- Uploader state is inconsistent between `save` and `commit`. For example, reading `my_object.file_url.url` will return a bogus url if I read before commit.
- A file might not be uploaded after a successful commit. For example, if there is a network failure. This causes the transaction to not be rolled back and invalid records being recorded.
- Even if the upload eventually completes, it can take an arbitrary amount of time, during which the record is invalid.

This reverts commit 665f225.

Fixes: carrierwaveuploader#2544
    @fsateler
    fsateler committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    88e3717 View commit details
    Browse the repository at this point in the history