Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage transaction rollback #2209

Merged
merged 1 commit into from Mar 30, 2019
Merged

Manage transaction rollback #2209

merged 1 commit into from Mar 30, 2019

Commits on Jul 26, 2017

  1. Manage transaction rollback 

      When we try to create new active record object into transaction and meet rollback:
    database row will not be created but uploader has created file in folder and doen't remove it.

  I changed behavior: now we store file only after commit action. This true and for update action in transaction.

  Changes in spec/orm/activerecord_spec.rb:
    - add tests which covers this flows
    - replace cleaning path from 'file path' to 'public_path' folder. Cause folder 'spec/fixtures/uploads ' is not used.
    Alexander Koshelapov committed Jul 26, 2017
    Copy the full SHA
    665f225 View commit details
    Browse the repository at this point in the history