Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading when not embedded. #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix uploading when not embedded. #188

wants to merge 1 commit into from

Conversation

jnfeinstein
Copy link

Currently the initial upload is being deleted as soon as it is uploaded.
The reason is that the "_new" value is being substituted for nil in
the given method.

Currently the initial upload is being deleted as soon as it is uploaded.
The reason is that the `"_new"` value is being substituted for `nil` in
the given method.
@jnfeinstein
Copy link
Author

jnfeinstein commented Aug 3, 2018

Fixes #168.

@rmm5t I assume you will be reviewing?

@aegorov
Copy link

aegorov commented Nov 28, 2018

have the same issue

@rmm5t
Copy link
Member

rmm5t commented Jan 19, 2023

Sorry, I know this PR has been sitting for a long while. Before considering any merge, I'll need this rebased with the master branch and a spec to confirm behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants