Conversation
Was this never merged? Is it because it's not needed or something else? // Johan |
Yes, I'm affected. We have seen strange behaviour where it stops to read logs when the file is rotated in scenarios where two dockers share same file system and one of them rotates the log and the other are streaming the log. |
I have merged it in my own fork, just need to figure out how to build it =) |
Well, since the upstream merge doesn't seem to be happening, guess we'll merge it here, then. |
Thank you =) Would you please include binaries as well? |
I managed to build it using go 1.12.5 and info from your Dockerfile. However, one thing that puzzled me was I could not use the source code from the release. I had to use go get from github instead of the tar.gz. I hope this can help someone =)
|
Hm, I made a release (v0.2.2) which should have built binaries as well. Looks like one of the build tools ( |
@jryberg Release now works! |
Thank you.
I can also confirm that we had no hiccups with the latest version. Rotated
logs works just fine now.
…On Tue, May 21, 2019, 12:36 Calle Pettersson ***@***.***> wrote:
@jryberg <https://github.com/jryberg> Release now works!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8?email_source=notifications&email_token=AAGMOJ6JO3QBCIAFMMZ3SX3PWPGCZA5CNFSM4ESFZEDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV3PZBA#issuecomment-494337156>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGMOJYAZK5SOECMLTQCCFTPWPGCZANCNFSM4ESFZEDA>
.
|
Fixes #5
This depends on a manual merge of fsnotify #205 in the vendor directory, which is pretty hacky. Asked for some attention on that PR.