Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

Update hpcloud/tail and fsnotify #8

Merged
merged 1 commit into from May 19, 2019
Merged

Update hpcloud/tail and fsnotify #8

merged 1 commit into from May 19, 2019

Conversation

carlpett
Copy link
Owner

Fixes #5

This depends on a manual merge of fsnotify #205 in the vendor directory, which is pretty hacky. Asked for some attention on that PR.

@jryberg
Copy link

jryberg commented May 13, 2019

Was this never merged? Is it because it's not needed or something else?

// Johan

@carlpett
Copy link
Owner Author

Hi @jryberg,
This seems to have fallen of the radar a bit. I was hoping for the linked PR in fsnotify to be merged so this one would not be needed (it essentially "fakes" the merge, so we'd diverge from upstream).
However, that PR doesn't have much activity... Are you affected by #5?

@jryberg
Copy link

jryberg commented May 16, 2019

Yes, I'm affected. We have seen strange behaviour where it stops to read logs when the file is rotated in scenarios where two dockers share same file system and one of them rotates the log and the other are streaming the log.

@jryberg
Copy link

jryberg commented May 17, 2019

I have merged it in my own fork, just need to figure out how to build it =)

@carlpett
Copy link
Owner Author

Well, since the upstream merge doesn't seem to be happening, guess we'll merge it here, then.

@carlpett carlpett merged commit 8422fa4 into master May 19, 2019
@jryberg
Copy link

jryberg commented May 19, 2019

Thank you =)

Would you please include binaries as well?

@jryberg
Copy link

jryberg commented May 19, 2019

I managed to build it using go 1.12.5 and info from your Dockerfile.

However, one thing that puzzled me was I could not use the source code from the release. I had to use go get from github instead of the tar.gz.

I hope this can help someone =)

FROM golang:1.12 AS build

RUN go version && \
    go get -v -u github.com/kardianos/govendor && \
    go get -v -u github.com/carlpett/stream_exporter && \
    go install github.com/kardianos/govendor
WORKDIR /go/src/github.com/carlpett/stream_exporter
RUN govendor build +p

@carlpett
Copy link
Owner Author

Hm, I made a release (v0.2.2) which should have built binaries as well. Looks like one of the build tools (promu) has broken backwards compatibility.
I'm out travelling at the moment, but will try to fix it and make a "real" release.

@carlpett
Copy link
Owner Author

@jryberg Release now works!

@jryberg
Copy link

jryberg commented May 21, 2019 via email

@carlpett carlpett deleted the fix-tail-reopen branch October 20, 2019 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tail rotated log files
2 participants