Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Migrate from require to readFileSync in configurationVault #928

Merged
merged 3 commits into from Sep 29, 2022
Merged

♻️ Migrate from require to readFileSync in configurationVault #928

merged 3 commits into from Sep 29, 2022

Conversation

aaditmshah
Copy link
Contributor

Description

  1. Migrate from require to readFileSync as described in ♻️ Migrate cli to ESM #926 (review).
  2. Migrate from require to import statements for mockProcessExit in unit tests.
  3. Migrate from require to dynamic import for buildFetchOptions unit tests.

Tests

  • All tests passed.

@aaditmshah aaditmshah mentioned this pull request Sep 29, 2022
Merged
2 tasks
@carloscuesta carloscuesta changed the title Migrate from require to readFileSync, import statements, and dynamic imports. ♻️ Migrate from require to readFileSync Sep 29, 2022
@carloscuesta carloscuesta changed the title ♻️ Migrate from require to readFileSync ♻️ Migrate from require to readFileSync in configurationVault Sep 29, 2022
@carloscuesta carloscuesta merged commit 2c13df3 into carloscuesta:esmodules-migration Sep 29, 2022
@carloscuesta
Copy link
Owner

Thanks!

@aaditmshah aaditmshah deleted the esmodules-migration branch September 29, 2022 17:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaditmshah @carloscuesta