New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hub: Add IAP verification #3059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests don’t quite pass…??? It took a tragically long time to get anything working but it’ll be worth it to have more conventional HTTP mocks, IMO
nesting oops!
so much cleaner!!
On this page it looks like the response has a wrapper? https://developers.google.com/android-publisher/api-ref/rest/v3/purchases.products/get
backspace
force-pushed
the
hub/verify-iap-cs-4145
branch
from
July 6, 2022 16:07
ddae341
to
2cb9128
Compare
Aierie
reviewed
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat! How can I try stuff out for this PR?
I think it’s omgtoosoon to try out Google but there’s an example Apple receipt in the issue you can try 🤓 |
Co-authored-by: Aierie <39579264+Aierie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the stubbed implementation of the
InAppPurchases
service. In the case of Google Play purchase validation, it does not include the required authentication code, which looks to be quite involved and not worth adding until it can be truly exercised, pending completion of necessary setup tasks. There’s a new issue to ensure followup on this.It introduces
msw
for HTTP mocking, but I had to use an older version because of import problems.