Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hub: Add IAP verification #3059

Merged
merged 18 commits into from Jul 7, 2022
Merged

hub: Add IAP verification #3059

merged 18 commits into from Jul 7, 2022

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Jul 4, 2022

This replaces the stubbed implementation of the InAppPurchases service. In the case of Google Play purchase validation, it does not include the required authentication code, which looks to be quite involved and not worth adding until it can be truly exercised, pending completion of necessary setup tasks. There’s a new issue to ensure followup on this.

It introduces msw for HTTP mocking, but I had to use an older version because of import problems.

These tests don’t quite pass…??? It took a tragically
long time to get anything working but it’ll be worth
it to have more conventional HTTP mocks, IMO
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

ssr-web test results

    1 files  ±0      1 suites  ±0   11s ⏱️ +2s
176 tests ±0  176 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8a9895f. ± Comparison against base commit d7ef333.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

web-client test results

    1 files  ±0      1 suites  ±0   1m 12s ⏱️ -1s
540 tests ±0  540 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8a9895f. ± Comparison against base commit d7ef333.

♻️ This comment has been updated with latest results.

@backspace backspace marked this pull request as ready for review July 6, 2022 17:00
@backspace backspace requested a review from Aierie July 6, 2022 17:00
Copy link
Contributor

@Aierie Aierie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat! How can I try stuff out for this PR?

packages/hub/config/test.cjs Outdated Show resolved Hide resolved
packages/hub/services/in-app-purchases.ts Outdated Show resolved Hide resolved
packages/hub/services/in-app-purchases.ts Outdated Show resolved Hide resolved
packages/hub/node-tests/services/in-app-purchases-test.ts Outdated Show resolved Hide resolved
packages/hub/services/in-app-purchases.ts Show resolved Hide resolved
packages/hub/services/in-app-purchases.ts Show resolved Hide resolved
@backspace
Copy link
Contributor Author

This is neat! How can I try stuff out for this PR?

I think it’s omgtoosoon to try out Google but there’s an example Apple receipt in the issue you can try 🤓

@backspace backspace merged commit 5c2e11e into main Jul 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the hub/verify-iap-cs-4145 branch July 7, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants