Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renamed cops #8

Merged
merged 1 commit into from Dec 2, 2019
Merged

Conversation

dylnclrk
Copy link
Member

@dylnclrk dylnclrk commented Dec 2, 2019

Layout/Align hash was renamed (#7) in Rubocop v0.77 (rubocop/rubocop#7077).

Change our conventions accordingly.

Comment on lines 28 to 32
Layout/AlignHash:
Layout/HashAlignment:
Enabled: false

Layout/CaseIndentation:
Enabled: false

Layout/IndentFirstArrayElement:
Layout/FirstArrayElementIndentation:
EnforcedStyle: consistent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sort these alphabetically by cop name?

Layout/AlignHash, and other cops were renamed in Rubocop 0.77
(see #7). Change the config accordingly.
@dylnclrk dylnclrk force-pushed the bugs/hash-alignment-cop-name-change branch from 9456ff9 to 7a07abc Compare December 2, 2019 22:22
@dylnclrk dylnclrk changed the title Fix renamed cop Fix renamed cops Dec 2, 2019
Copy link
Contributor

@mattbrictson mattbrictson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dylnclrk dylnclrk merged commit 4076c5b into master Dec 2, 2019
@dylnclrk dylnclrk deleted the bugs/hash-alignment-cop-name-change branch December 2, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants