Remove reference to performance cop #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance cops were moved out in to their own gem in Rubocop 0.68[1], which means that referring to them logs a warning like: `Warning: unrecognized cop Performance/Casecmp found in …` Remove the reference to the performance cop to resolve this. Note that it may negatively impact users who do not upgrade to 0.68, as this previously disabled Performace cop will now be enabled until they upgrade to 0.68. [1]: rubocop/rubocop#5977
|
I am in favor of this PR to just remove # Performance/Casecmp
# bad
str.downcase == 'abc'
str.upcase.eql? 'ABC'
'abc' == str.downcase
'ABC'.eql? str.upcase
str.downcase == str.downcase
# good
str.casecmp('ABC').zero?
'abc'.casecmp(str).zero?
|
|
Oops, I just realized disabling the cop is the whole point of this part of the conventions file. 🤦♂ A vote from me not to merge, then. |
|
Closing this! (in favor of the other approach) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance cops were moved out in to their own gem in Rubocop 0.68, which
means that referring to them in our default
.rubocop.ymlwill log a warning like,when rubocop is run.
To resolve this we can either:
rubocop-performanceas a dependency in Raygun, and addrequire: rubocop-performanceto our default.rubocop.yml.Removing the reference seems like the lower impact change, but it may negatively impact users who do not upgrade to 0.68, as this previously disabled Performace/Casecmp cop will now be enabled until they upgrade to 0.68.