Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit configuration to match changes to prettier #183

Merged
merged 1 commit into from Oct 28, 2020

Conversation

zygoloid
Copy link
Contributor

See prettier/prettier#9459 for details. Unclear whether this is a prettier bug or an npm bug, but pre-commit fails with new repositories without this change.

See prettier/prettier#9459 for details. Unclear whether this is a prettier bug or an npm bug, but pre-commit fails with new repositories without this change.
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Oct 28, 2020
@zygoloid zygoloid requested a review from jonmeow October 28, 2020 02:11
@chandlerc
Copy link
Contributor

FWIW, I think this makes sense, but would prefer to leave for Jon as he's touched al the pre-commit stuff more than I have.

@jonmeow jonmeow merged commit 96ead76 into trunk Oct 28, 2020
@jonmeow
Copy link
Contributor

jonmeow commented Oct 28, 2020

@zygoloid zygoloid deleted the zygoloid-prettier-pre-commit-repo branch October 28, 2020 19:15
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
See prettier/prettier#9459 for details. Unclear whether this is a prettier bug or an npm bug, but pre-commit fails with new repositories without this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes PR meets CLA requirements according to bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants