test(interstitialscreen): Add default state AVT check #5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangeethababu9223
requested review from
kennylam and
ariellalgilmore
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
szinta
reviewed
May 15, 2024
szinta
approved these changes
May 16, 2024
annawen1
approved these changes
May 21, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 21, 2024
ba65093
16 checks passed
paul-balchin-ibm
pushed a commit
to paul-balchin-ibm/ibm-products
that referenced
this pull request
May 23, 2024
…system#5170) * test(InterstitialScreen): default avt * test(InterstitialScreen): add default avt * test(InterstitialScreen): disable lint for tabindex in scollable div * test(InterstitialScreen): add default avt * test(interstitialscreen): remove interstitialscreen from cspell.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5063
Add default state AVT check for
InterstitialScreenSince there is no default option in the story, added AVT check for
Full Screen.What did you change?
Created
e2e/components/InterstitialScreen/InterstitialScreen-test.avt.e2e.jsHad to disable lint for
non interactive tabindexsince the div is scrollable.How did you test and verify your work?
yarn avt