refactor(CreateFullPageStep): add TypeScript types #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnacioBecerra
requested review from
davidmenendez and
emyarod
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/ibm-products/src/components/CreateFullPage/CreateFullPageStep.tsx
Outdated
Show resolved
Hide resolved
…PageStep.tsx Co-authored-by: Matt Gallo <mdgallo@us.ibm.com>
davidmenendez
previously approved these changes
May 14, 2024
makafsal
requested changes
May 22, 2024
packages/ibm-products/src/components/CreateFullPage/CreateFullPageStep.tsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/CreateFullPage/CreateFullPageStep.tsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/CreateFullPage/CreateFullPageStep.tsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/CreateFullPage/CreateFullPageStep.tsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/CreateFullPage/CreateFullPageStep.tsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/CreateFullPage/CreateFullPageStep.tsx
Outdated
Show resolved
Hide resolved
IgnacioBecerra
added
status: one more review 👀
and removed
status: waiting for author 💬
labels
IgnacioBecerra
commented
May 29, 2024
| * @param {boolean | undefined} useResetCreateComponent.invalid | ||
| * @param {boolean | undefined} useResetCreateComponent.shouldIncludeStep | ||
| * @param {string | undefined } useResetCreateComponent.secondaryLabel | ||
| * @param {string | node} useResetCreateComponent.title | ||
| */ |
There was a problem hiding this comment.
@makafsal Due to CreateFullPageStep.tsx having these props be optional, when they are passed into this function they can be considered either their type, or undefined, if they are not passed in. However this function "requires" the props to not be undefined to "work", but in reality there are multiple checks that include the required props anyway. To not have to refactor this file within this same PR, this is a temporary solution to the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4512
This PR changes the CreateFullPageStep file and component to use typescript
What did you change?
The file to be
tsxand used types for the propsHow did you test and verify your work?
ran tests and builds locally