Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(NotificationsPanel): added typescript support to the component #5154

Merged

Conversation

devadula-nandan
Copy link
Contributor

Contributes to #4506

added typescript support to the component

What did you change?

packages/ibm-products/src/components/NotificationsPanel/NotificationsPanel.tsx

How did you test and verify your work?

local ide, storybook renders as expected

Copy link

netlify bot commented May 13, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 95ec7ae
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6645cd8eb8b14e0008095896
😎 Deploy Preview https://deploy-preview-5154--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devadula-nandan devadula-nandan marked this pull request as ready for review May 16, 2024 06:44
@devadula-nandan devadula-nandan requested a review from a team as a code owner May 16, 2024 06:44
@devadula-nandan devadula-nandan requested review from davidmenendez and matthewgallo and removed request for a team May 16, 2024 06:44
Copy link
Contributor

@anamikaanu96 anamikaanu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. 🎉

@devadula-nandan devadula-nandan added this pull request to the merge queue May 16, 2024
Merged via the queue into carbon-design-system:main with commit 63a8347 May 16, 2024
16 checks passed
@devadula-nandan devadula-nandan deleted the nandan-v2-4506 branch May 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript types to NotificationsPanel
3 participants