refactor(SingleAddSelect): implement typescript types #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makafsal
requested review from
davidmenendez and
emyarod
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emyarod
reviewed
May 14, 2024
packages/ibm-products/src/components/AddSelect/AddSelectBody.tsx
Outdated
Show resolved
Hide resolved
davidmenendez
requested changes
May 16, 2024
There was a problem hiding this comment.
looks great. one last thing- similarly to the dataspreadsheet refactor, can you move the types into their own file? d4c4395#diff-e0e53665040074874d795a3d1adad8fbb56210c909296066a7e87fcfb25e10b9
|
@davidmenendez sure, refactored. |
davidmenendez
approved these changes
May 21, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 22, 2024
a20e768
17 checks passed
paul-balchin-ibm
pushed a commit
to paul-balchin-ibm/ibm-products
that referenced
this pull request
May 23, 2024
…system#5144) * refactor(SingleAddSelect): implement typescript types * refactor: types for addSelect, addSelectSort, addSelectBody, Tearsheet * refactor(MultiAddSelect): implement types * refactor: correct any types * chore(AddSelectBody): remove unwanted comment * refactor: move common types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5117 #5123 #5122
What did you change?
Moved these
.jsfiles to.tsx.packages/ibm-products/src/components/SingleAddSelect/SingleAddSelect.tsxpackages/ibm-products/src/components/AddSelect/AddSelect.tsxpackages/ibm-products/src/components/AddSelect/AddSelectSort.tsxpackages/ibm-products/src/components/AddSelect/AddSelectBody.tsxpackages/ibm-products/src/components/Tearsheet/Tearsheet.tsxpackages/ibm-products/src/components/MultiAddSelect/MultiAddSelect.tsxBecause all these components are connected, hence I migrated them together to avoid conflicts in future.
How did you test and verify your work?
Storybook