feat(Guidebanner): convert to .tsx #5141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-balchin-ibm
requested review from
annawen1 and
sangeethababu9223
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was
linked to
issues
May 9, 2024
| /** | ||
| * The description of the element. | ||
| */ | ||
| description: string | ReactNode; |
There was a problem hiding this comment.
I believe string is also considered a ReactNode so you could just specify description: ReactNode
Suggested change
| description: string | ReactNode; | |
| description: ReactNode; |
| <Button | ||
| {...rest} | ||
| className={cx(blockClass, className)} | ||
| iconDescription={'Crossroads'} |
There was a problem hiding this comment.
Can you update this so it's not a hard coded string? This component might need a new prop, iconDescription
matthewgallo
requested changes
May 22, 2024
…m#5129) * refactor(CreateInfluencer): add typescript types * refactor(CreateInfluencer): update setpdata type * refactor(createinfluencer): fix build error
…tem#5256) * test(NoTagsEmptyState): add default state AVT test * fix(test): rename file to include -test * fix(cspell): remove from file
…system#5250) * feat: add triage label to all opened and reopened issues * chore: update action name * chore: fix spelling error Co-authored-by: elysia <elysia.hwang@gmail.com> --------- Co-authored-by: elysia <elysia.hwang@gmail.com>
- @carbon/ibm-cloud-cognitive-core@2.18.1 - @carbon/ibm-products@2.39.0 - @carbon/ibm-products-styles@2.37.0
…em#5247) * test(CreateSidePanel): add default state AVT test * test(CreateSidePanel): add default state AVT test * test(CreateSidePanel): add default state AVT test * test(CreateSidePanel): resolve avt issue * test(createsidepanel): resolve avt issue * fix: setup dev prefix in avt env * test(Ci.yml): resolve AVT issue * test(CreateSidePanel): review changes * test(OptionTile): resolve avt issue --------- Co-authored-by: Matt Gallo <mdgallo@us.ibm.com>
…ystem#5280) * test(EditTearsheetForm): add default state AVT check * test(EditTearsheetForm): revert unwanted change
…stem#5086) * chore(CreateTearsheetStep): changed extension from js to tsx * refactor(CreateTearsheetStep): fixed few ts errors * fix: lint error * fix: lint error * chore: cleanup * refactor(CreateTearsheetStep): revert to previous way of accessing object props * refactor(CreateTearsheetStep): added conditional prop types and title prop fix * fix(CreateTearsheetStep): fix a test case, and snapshot * fix(CreateTearsheetStep): lint fix * refactor: reduced redundancy of descriptions * refactor: better logic for conditional props
…bon-design-system#5242) * test(EditAndUpdate): edit and update component avt default tests * chore(ci): set env variable for storybook prefix * chore(ci): set env variable earlier * chore(ci): set env variable earlier * test(CreateTearsheetNarrow): fix CreateTearsheetNarrow avt test * chore(avt): revert ci changes * test(EditAndUpdate): update tests * chore(env): remove env file --------- Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
…ystem#5166) * test(NotificationsPanel): add default state avt test * Update e2e/components/NotificationsPanel/NotificationsPanel-test.avt.e2e.js * test(NotificationPanel): add click to test * test(NotificationsPanel): add name attribute to div * test(NotificationsPanel): remove aria-label from div * chore(NotificationsPanel): import prefix from settings file
…nd currently visible rows in virtualized Datagrids (carbon-design-system#5255) * feat(Datagrid): return currently visible row data for virtual scroll * chore: add additional docs * chore: remove console log * chore: use correct naming Co-authored-by: Nandan Devadula <47176249+devadula-nandan@users.noreply.github.com> --------- Co-authored-by: Nandan Devadula <47176249+devadula-nandan@users.noreply.github.com>
…system#5170) * test(InterstitialScreen): default avt * test(InterstitialScreen): add default avt * test(InterstitialScreen): disable lint for tabindex in scollable div * test(InterstitialScreen): add default avt * test(interstitialscreen): remove interstitialscreen from cspell.json
* fix: adds short text option for pageheader * fix: better short title handling * fix: remove unnecessary prop check * fix: update short title story title * fix: short title story fix * fix: story name typo * fix: revert code removal --------- Co-authored-by: elysia <elysia.hwang@gmail.com>
…n-design-system#5264) * fix(Tearsheet): properly focus specified element with new hook * chore: update comment
…esign-system#5265) * test(NotificationsEmptyState): added default state AVT test * fix(test): rename file to include -test * fix(cspell): remove from list
…system#5144) * refactor(SingleAddSelect): implement typescript types * refactor: types for addSelect, addSelectSort, addSelectBody, Tearsheet * refactor(MultiAddSelect): implement types * refactor: correct any types * chore(AddSelectBody): remove unwanted comment * refactor: move common types
…5171) * test(WebTerminal): add default state AVT check * test(WebTerminal): review changes * test(WebTerminal): review change * test(WebTerminal): review change * test(webterminal): review changes * test(WebTerminal): review changes * test(WebTerminal): resolve test issue * test(WebTerminal): review changes * test(WebTerminal): review change Co-authored-by: Anna Wen <54281166+annawen1@users.noreply.github.com> --------- Co-authored-by: Anna Wen <54281166+annawen1@users.noreply.github.com>
* fix(Tearsheet): implement focus return property 'launcherButtonRef' * fix(sidePanel): implement return focus property * refactor(sidePanel): change in property type * chore(tearsheetShell): ts-ignore * chore: implement sidepanel and tearsheet stories * test(SidePanel): implement test for launch button focus return * test(tearsheet): implement test for focus return
* test(inlinetip): add default state avt * chore(inlinetip): copyright updated
paul-balchin-ibm
requested review from
elycheea,
kennylam and
a team
as code owners
|
Closing. Made changes, merged latest, push was rejected, followed git instructions to fix, now have other people's gazillion changes. Please see replacement PR #5321 |
auto-merge was automatically disabled
May 23, 2024 13:31
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4487, #4488, #4489, #4490
This PR converts
Guidebanner,GuidebannerElement,GuidebannerElementButton, andGuidebannerElementLinkto TypeScript.What did you change?
How did you test and verify your work?
storybook build and type checks