Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(createInfluencer): Add Typescript types #5129

Conversation

sangeethababu9223
Copy link
Member

Contributes to #4517

Add Typescript types to CreateInfluencer

What did you change?

Changed the CreateInfluencer.js to CreateInfluencer.tsx with typescript type support

How did you test and verify your work?

Storybook

Copy link

netlify bot commented May 9, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit fff45f1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6644428d48b0f6000847eccd
😎 Deploy Preview https://deploy-preview-5129--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review May 9, 2024 06:47
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner May 9, 2024 06:47
@sangeethababu9223 sangeethababu9223 requested review from davidmenendez and emyarod and removed request for a team May 9, 2024 06:47
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like there is a type mismatch which is causing CI to fail

@sangeethababu9223 sangeethababu9223 linked an issue May 14, 2024 that may be closed by this pull request
@sangeethababu9223
Copy link
Member Author

it looks like there is a type mismatch which is causing CI to fail

Thanks @emyarod.
The type issue is fixed now.

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue May 20, 2024
Merged via the queue into carbon-design-system:main with commit c93cf1f May 20, 2024
16 checks passed
@sangeethababu9223 sangeethababu9223 deleted the refactor/create-influencer-ts-types branch May 20, 2024 11:04
paul-balchin-ibm pushed a commit to paul-balchin-ibm/ibm-products that referenced this pull request May 23, 2024
…m#5129)

* refactor(CreateInfluencer): add typescript types

* refactor(CreateInfluencer): update setpdata type

* refactor(createinfluencer): fix build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript types to CreateInfluencer
4 participants