refactor(CreateTearsheetStep): add typescript types #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…bm-products into nandan-v2-4510
devadula-nandan
requested review from
annawen1 and
sangeethababu9223
and removed request for
a team
anamikaanu96
approved these changes
May 21, 2024
annawen1
approved these changes
May 21, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 21, 2024
0108f2b
16 checks passed
paul-balchin-ibm
pushed a commit
to paul-balchin-ibm/ibm-products
that referenced
this pull request
May 23, 2024
…stem#5086) * chore(CreateTearsheetStep): changed extension from js to tsx * refactor(CreateTearsheetStep): fixed few ts errors * fix: lint error * fix: lint error * chore: cleanup * refactor(CreateTearsheetStep): revert to previous way of accessing object props * refactor(CreateTearsheetStep): added conditional prop types and title prop fix * fix(CreateTearsheetStep): fix a test case, and snapshot * fix(CreateTearsheetStep): lint fix * refactor: reduced redundancy of descriptions * refactor: better logic for conditional props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4510
added typescript types to the component
What did you change?
packages/ibm-products/src/components/CreateTearsheet/CreateTearsheetStep.js -> tsx
How did you test and verify your work?
storybook renders as expected
locally writing a test component and verifying the props in vs code manually.