Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(EditTearsheet): add TypeScript types #5082

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

IgnacioBecerra
Copy link
Contributor

Contributes to #
#4282

This PR converts the EditTearsheet component to using TypeScript

What did you change?

packages/ibm-products/src/components/EditTearsheet/EditTearsheet.tsx

How did you test and verify your work?

Through Storybook and type checks.

@IgnacioBecerra IgnacioBecerra requested a review from a team as a code owner May 3, 2024 23:10
Copy link

netlify bot commented May 3, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 22270bb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6657a0f849db430008b73231
😎 Deploy Preview https://deploy-preview-5082--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IgnacioBecerra IgnacioBecerra requested a review from a team as a code owner May 9, 2024 06:14
@IgnacioBecerra IgnacioBecerra requested review from annawen1 and sangeethababu9223 and removed request for a team May 9, 2024 06:14
Copy link
Member

@sangeethababu9223 sangeethababu9223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants