Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colors): initialize color vars with default values #8440

Merged
merged 4 commits into from
Apr 22, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Apr 16, 2021

Closes #8069

This PR initializes color vars in the root of the color mixins file and assigns them to their default values

Testing / Reviewing

Dart Sass deprecation warnings should no longer be emitted during the build process and colors should no longer receive the !global flag

@netlify
Copy link

netlify bot commented Apr 16, 2021

Deploy preview for carbon-elements ready!

Built with commit ba10900

https://deploy-preview-8440--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 16, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit ba10900

https://deploy-preview-8440--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit d360dd5 into carbon-design-system:main Apr 22, 2021
@emyarod emyarod deleted the 8069-sass-var-global branch April 27, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 5 with sass (dart scss) gives warningns
3 participants