fix(menu): include leave intent delay for sub menus #16466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sub menu can accidentally trigger a premature closure of the sub menu in the following cases: - the mouse moves across and down as the user selects a lower sub menu, causing the mouse to leave the menuItem. - the menu has a scroll bar, as the mouse crosses this to enter the sub menu it triggers the closure before the user can access the sub menu. Including a delay in the closure allows for the users mouse to reenter the submenu and cancel the closure of the menu.
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
tay1orjones
approved these changes
May 14, 2024
|
@Kilian-Collender I can reproduce the avt error in storybook
|
tay1orjones
reviewed
May 14, 2024
auto-merge was automatically disabled
May 15, 2024 09:10
Head branch was pushed to by a user without write access
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit May 15, 2024
1771cb6
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16395
Menu component does not protect access to refs in focusItem by adding protection to the accessing of the refs.
Changelog
New
Adds leave intent delay for sub menu as it can accidentally trigger a premature closure of the sub menu in the following cases:
Including a delay in the closure allows for the users mouse to reenter the submenu and cancel the closure of the menu.
Changed
Testing / Reviewing
Unit tests have been added to validate the opening and closing of the sub menu using fake timers.
Manual testing can be easily done by opening the submenu and quickly moving the mouse out and back into the menu item and the menu will close.