chore(deps): bump and fix prettier #13675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
falsepopsky
changed the title
tay1orjones
approved these changes
May 9, 2023
alisonjoseph
approved these changes
May 11, 2023
alisonjoseph
added
status: merge conflict 🚫
and removed
status: one more review 👀
labels
falsepopsky
force-pushed
the
chore/fix-prettier
branch
from
5dfa566
to
deb8ab2
Compare
|
conflict solved, thanks |
SunnyJohal
pushed a commit
to SunnyJohal/carbon
that referenced
this pull request
May 23, 2023
* chore(deps): bump prettier to latest * fix: format files with prettier --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
prettierto latest.prettierfromdevDependenciesin prettier-config-carbon.--cacheflag inlint-staged.--cacheinformat:diffscript.Why
--cacheoption, which had a bug. However, this bug was fixed and released on V8prettier-config-carbonis a shareable configuration that does not requireprettierasdevDependency. Instead, it should be added as apeerDependencyto indicate that this configuration requires versionv2.xof theprettierpackage.--cacheflag in my old pr.Changelog
Changed
prettierto latest.Removed
prettierfromdevDependenciesinprettier-config-carbonTesting / Reviewing
CI should pass.