Types/tabs

[kubijo]

Closes #13540, #13541

Changelog

New

• add typescript types to the Tabs components family

[netlify]

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	c569bf3
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-components-react/deploys/6491a59322771c000824100d
😎 Deploy Preview	https://deploy-preview-13635--carbon-components-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	c569bf3
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/6491a5939ca3240008141241
😎 Deploy Preview	https://deploy-preview-13635--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[francinelucca]

This is looking good! Behavior works as expected, just a couple change requests

[tay1orjones]

@kubijo thanks again for this! There's some remaining feedback to address here. I'd like to get this in but if it's stalled out we'll close after a few days.

[kubijo]

@kubijo thanks again for this! There's some remaining feedback to address here. I'd like to get this in but if it's stalled out we'll close after a few days.

I've got a rebase conflict seemingly due to Tab.js being deleted here #13735
What's up with that? What do we do with my rewrites then?

[kubijo]

As far as I can tell, someone moved a lot of code here and as a result, we're getting MANY new errors in the Tabs.tsx module (for example)… my patience with such a refactor is fleeting, and I really don't care for it…

Is there any chance of moving this to the author of those changes (them having the context of what was changed) and using this as a source of entropy?

[tay1orjones]

@kubijo sorry for the churn, packages/react/src/components/Tab/index.js was deleted because it's not being used. It was legacy code behind a v11 feature flag that has been permanently set true. You've already done the typings for the correct/new Tab in Tabs.tsx

There's been some new features added to Tabs recently, but I think it would only impact typings for two new props, dismissable and onTabCloseRequest. The delta shouldn't be too large.

[kubijo]

@kubijo sorry for the churn, packages/react/src/components/Tab/index.js was deleted because it's not being used. It was legacy code behind a v11 feature flag that has been permanently set true. You've already done the typings for the correct/new Tab in Tabs.tsx

There's been some new features added to Tabs recently, but I think it would only impact typings for two new props, dismissable and onTabCloseRequest. The delta shouldn't be too large.

Can someone on your side do the rebase, then? You (as in maintainers) should have a write access, I believe.

[francinelucca]

🚀

[tay1orjones]

Thanks for your help @francinelucca!