Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add latest react, react-dom to dependencies #11185

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Apr 8, 2022

Ref #11308

{{short description}}

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@netlify
Copy link

netlify bot commented Apr 8, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 363d59e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/625061b84f904e0009861d17
😎 Deploy Preview https://deploy-preview-11185--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 8, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 363d59e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/625061b8a1ff680008f9f4d1
😎 Deploy Preview https://deploy-preview-11185--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones
Copy link
Member

@joshblack what are the additional considerations here to ensure the components work with v18?

@joshblack
Copy link
Contributor Author

@tay1orjones my plan roughly was:

  • Update project to React 18 through resolutions
  • Enable StrictMode in storybook
  • Run test suite for both React 18 and React 17

Let me know if there is anything else you think we should go for 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants