Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI doc update - Select & Date picker #4060

Merged

Conversation

Kritvi-bhatia17
Copy link
Contributor

Closes #4011 & #4038

AI work:

Changelog (both components)

Added in the Usage tab

  • Inline notification
  • AI Presence Section
  • AI Revert Section

Added in the Style tab

  • AI Styling table
  • AI Default and Fluid states for respective components

Bug fixes:

Changelog (only Select)

Added in the Style tab

  • Page description + Anchor links
  • Feedback section

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 2:19pm

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When flipping between the images, the scale and positioning shift slightly. Not sure if that's worth fixing though. Otherwise looks great to me!

@Kritvi-bhatia17
Copy link
Contributor Author

Visit Preview

Thanks, @tay1orjones! So, if I understand correctly, the shift you're referring to is due to the default and fluid components in the images, or something else? 🤔

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No notes. Ship it!

@aagonzales
Copy link
Member

Oh seeing, @tay1orjones comment now. We do try to align some parts of the default/fluid images so they don't bounce so much. Sometimes its aligning the bases line or sometime its the text or icons in the field. Look at the "keyboard" image under "interactions" on the select page.

Its not a deal break but is a nice visual polish moment to look out for.

@Kritvi-bhatia17
Copy link
Contributor Author

Hi @tay1orjones, @aagonzales, I tried fixing the positioning shift, please have a look!

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I just spotted one more place on the style tab where we should swap out "default" for "non-AI"

src/pages/components/date-picker/style.mdx Outdated Show resolved Hide resolved
src/pages/components/select/style.mdx Outdated Show resolved Hide resolved
Kritvi-bhatia17 and others added 2 commits May 15, 2024 17:36
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@Kritvi-bhatia17 Kritvi-bhatia17 enabled auto-merge (squash) May 15, 2024 14:12
@Kritvi-bhatia17 Kritvi-bhatia17 merged commit c9bce4c into carbon-design-system:main May 15, 2024
7 checks passed

A date picker can toggle between the AI variant and the non-AI variant depending
on the user’s interaction. If the user manually overrides the AI-suggested
content then the input will change from the AI variant to the default variant.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kritvi-bhatia17 just noticed this default to non-AI variant change in the usage tab for Date picker and Select component, rest is all good! 🚀

"content then the input will change from the AI variant to the non-AI variant."


A select can toggle between the AI variant and the non-AI variant depending on
the user’s interaction. If the user manually overrides the AI-suggested content
then the input will change from the AI variant to the default variant. Once
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"content then the input will change from the AI variant to the non-AI variant."

@Kritvi-bhatia17
Copy link
Contributor Author

Thanks @alina-jacob! I also just noticed it while updating the other component will fix this in the upcoming PR!

Copy link
Contributor

@alina-jacob alina-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select component: Input field suggestions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Kritvi-bhatia17, just one more observation, the input field in this image should show some 'AI selected option'
And the menu item will subsequently reflect that (for both default and fluid states)

Here's an example from the dropdown component:
image

Subsequently, while showing the revert image, just change the option item.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example for revert state (where user has changed the AI selected option)

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alina-jacob
I noticed that was already updating that in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI documentation: Add AI docs for Date Picker
5 participants