Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ai-alina #4059

Merged
merged 22 commits into from
May 16, 2024
Merged

ai-alina #4059

merged 22 commits into from
May 16, 2024

Conversation

alina-jacob
Copy link
Contributor

@alina-jacob alina-jacob commented May 8, 2024 •
edited

Closes ##4036 and #4039

Changelog

New

Added in the Usage tab

  • Inline notification
  • Anchor links
  • AI Presence Section
  • AI Revert Section

Added in the Style tab

  • Anchor links
  • AI Styling table
  • AI Default and Fluid states for respective components

@alina-jacob alina-jacob requested review from a team as code owners May 8, 2024 15:02
@vercel Vercel
Copy link

vercel bot commented May 8, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:33pm

aagonzales
aagonzales reviewed May 8, 2024
View reviewed changes
src/pages/components/text-input/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/style.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/style.mdx Outdated Show resolved Hide resolved
@aagonzales
Copy link
Member

@alina-jacob I commented here the changes we were talking about in Slack. I only commented in the text input page. The number input will need similar updates.

Kritvi-bhatia17
Kritvi-bhatia17 requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alina! nice work 🔥
Just a few minor fixes

src/pages/components/number-input/style.mdx Outdated Show resolved Hide resolved
src/pages/components/number-input/style.mdx Outdated Show resolved Hide resolved
src/pages/components/number-input/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/number-input/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/number-input/style.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/style.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/usage.mdx Outdated Show resolved Hide resolved
alina-jacob and others added 13 commits May 9, 2024 19:17
@alina-jacob @aagonzales
Update src/pages/components/text-input/usage.mdx
8cacdd9 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@alina-jacob @aagonzales
Update src/pages/components/text-input/usage.mdx
38edf6e 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@alina-jacob @aagonzales
Update src/pages/components/text-input/usage.mdx
d92b468 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@alina-jacob @aagonzales
Update src/pages/components/text-input/usage.mdx
96f28af 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@alina-jacob @aagonzales
Update src/pages/components/text-input/style.mdx
2fc3d94 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@alina-jacob @aagonzales
Update src/pages/components/text-input/style.mdx
73edb83 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@alina-jacob @Kritvi-bhatia17
Update src/pages/components/number-input/style.mdx
1f15a92 
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
@alina-jacob @Kritvi-bhatia17
Update src/pages/components/number-input/style.mdx
d86897e 
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
@alina-jacob @Kritvi-bhatia17
Update src/pages/components/number-input/usage.mdx
1dc60a9 
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
@alina-jacob @Kritvi-bhatia17
Update src/pages/components/text-input/style.mdx
9173363 
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
@alina-jacob @Kritvi-bhatia17
Update src/pages/components/text-input/usage.mdx
5c784d5 
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
@alina-jacob @Kritvi-bhatia17
Update src/pages/components/number-input/style.mdx
56c61ea 
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
@alina-jacob @Kritvi-bhatia17
Update src/pages/components/number-input/usage.mdx
30a479d 
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
aagonzales
aagonzales reviewed May 10, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few more formatting things.

src/pages/components/text-input/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/style.mdx Outdated Show resolved Hide resolved
src/pages/components/text-input/style.mdx Outdated Show resolved Hide resolved
src/pages/components/number-input/style.mdx Outdated Show resolved Hide resolved
alina-jacob and others added 4 commits May 10, 2024 21:09
@alina-jacob @aagonzales
Update src/pages/components/text-input/usage.mdx
a59febc 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@alina-jacob @aagonzales
Update src/pages/components/text-input/style.mdx
53174bb 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@alina-jacob @aagonzales
Update src/pages/components/text-input/style.mdx
484bd90 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@alina-jacob @aagonzales
Update src/pages/components/number-input/style.mdx
dc2f420 
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
guidari
guidari approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@guidari guidari left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Vercel link for preview: https://carbondesignsystem-git-fork-alina-j-32ea40-carbon-design-system.vercel.app/

Kritvi-bhatia17
Kritvi-bhatia17 reviewed May 12, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alina-jacob, everything else seems great with the changes/updates! ✨
Just a quick question: since number input & text input include both default and fluid states, should we display both states under the usage tab under 'AI presence' section? 🤔
image

@alina-jacob
Copy link
Contributor Author

Hey @alina-jacob, everything else seems great with the changes/updates! ✨ Just a quick question: since number input & text input include both default and fluid states, should we display both states under the usage tab under 'AI presence' section? 🤔 image

The guideline doc showed just default so went with that, should we be showing default and fluid states for the usage tab as well @aagonzales?

@aagonzales
Copy link
Member

@alina-jacob I believe we discussed this in Slack, but we decided to include both the default and fluid tabs. Part of the work is also to now avoid the word "default" in the copy text. It should be changed to "non-AI" instead of "default"

Kritvi-bhatia17
Kritvi-bhatia17 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

aagonzales
aagonzales approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ship it!

@kodiakhq kodiakhq bot merged commit 69b2aa4 into carbon-design-system:main May 16, 2024
7 checks passed
@Kritvi-bhatia17
Copy link
Contributor

Hi @alina-jacob, just a small note - you might need to add the page description on the Number Input STYLE tab, similar to the Text Input.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@guidari guidari guidari approved these changes

@Kritvi-bhatia17 Kritvi-bhatia17 Kritvi-bhatia17 approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@laurenmrice laurenmrice Awaiting requested review from laurenmrice laurenmrice is a code owner automatically assigned from carbon-design-system/design

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alina-jacob @aagonzales @Kritvi-bhatia17 @guidari @alina-jacob-ibm