Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show light and dark theme applied using system preferences #4022

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lee-chase
Copy link
Member

Modern browsers and systems allow the user to configure a preference for light and dark modes. This should be obeyed where the user has not configured a theme for the current application.

Modern browsers and systems allow the user to configure a preference for light and dark modes. This should be obeyed where the user has not configured a theme for the current application.
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 5:28pm

@lee-chase lee-chase changed the title Show light and dark theme applied using system preferences feat: Show light and dark theme applied using system preferences Apr 16, 2024
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this! I wonder if we also want to include this in the storybook docs under the theme overview?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants