fix: nextjs images in storybook #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrosno
commented
May 4, 2022
| import clsx from 'clsx' | ||
|
|
||
| // `node_modules` import is necessary to not create a cyclically resolving alias | ||
| import Image from '../../../node_modules/next/image' |
There was a problem hiding this comment.
@jdharvey-ibm this isn't pretty but I don't know a better way.
|
Kudos, SonarCloud Quality Gate passed!
|
alisonjoseph
approved these changes
May 4, 2022
francinelucca
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this related fix from 13 days ago: storybookjs/storybook#17950 (comment)
This PR changes how Storybook processes Next.js images by using an alias instead of attempting to redefine the
next/imagecomponent.Changelog
New
Changed
Removed
Testing / reviewing
The assets page story should now work (it has Next.js images).