Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slider): support two knobs option #11567

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat(slider): support two knobs option #11567

wants to merge 16 commits into from

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #9798

Description

@carbon/react has two handles option available. The same is now implemented in @carbon/web-components

Changelog

New

  • Added Two handles option in storybook

Changed

  • Drag, click and keydown functionalities on slider updated to include two handles.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 22, 2024 •
edited

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11567/index.html

Built with commit: 44cd970a78329bddb194b61dc78eecbac20b03fc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 22, 2024 •
edited

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11567/index.html

Built with commit: 44cd970a78329bddb194b61dc78eecbac20b03fc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 22, 2024 •
edited

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11567/index.html

Built with commit: 44cd970a78329bddb194b61dc78eecbac20b03fc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 22, 2024 •
edited

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11567/index.html

Built with commit: 44cd970a78329bddb194b61dc78eecbac20b03fc

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review February 28, 2024 11:30
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner February 28, 2024 11:30
@sangeethababu9223 sangeethababu9223 requested review from emyarod, ariellalgilmore and a team and removed request for a team February 28, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slider: Support two knobs
3 participants
@sangeethababu9223 @ibmdotcom-bot @annawen1