Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ibmdotcom-styles) remove react classes from component styles #11218

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

feat(ibmdotcom-styles) remove react classes from component styles #11218

wants to merge 44 commits into from

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #11194

Description

Remove React classes from component styles

Changelog

Removed

  • Removed react classes from components in styles package

@sangeethababu9223
feat(ibmdotcom styles): remove react classes card compoenent
c228064
@sangeethababu9223
feat(ibmdotcom styles): remove react classes content block horizontal
211bcf7
@sangeethababu9223
feat(ibmdotco styles): remove react classes from content block media
049887e
@sangeethababu9223
feat(ibmdtcom styles): remove react classes content block mixed
c21f653
@sangeethababu9223
feat(ibmdotcom styles): remove react classes from content block segme…
0c92396 
…nted
@sangeethababu9223
feat(ibmdotcom styles): remove react classes from content block sample
8adf87b
@sangeethababu9223
feat(ibmdotcom styles): remove react classes from content group cards
91ee9e1
@sangeethababu9223
feat(ibmdotcom styles): remove react classes from content group picto…
9f25367 
…grams
@sangeethababu9223
feat(ibmdotcom styles): remove react classes from content group simple
d689252
@sangeethababu9223
feat(ibmdotcom styles): remove react classes from content item row
c18a8f0
@sangeethababu9223
feat(ibmdotcom styles): remove react classes from cta block
540b92e
@sangeethababu9223
feat(ibmdotcom styles): remove react classes from cta section
21a5a53
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023 •
edited

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11218/index.html

Built with commit: fdda8054c353e40a03b18b021e0f8315e5f765c1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023 •
edited

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11218/index.html

Built with commit: fdda8054c353e40a03b18b021e0f8315e5f765c1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023 •
edited

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11218/index.html

Built with commit: fdda8054c353e40a03b18b021e0f8315e5f765c1

@m4olivei m4olivei mentioned this pull request Dec 13, 2023
Open
@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review December 18, 2023 08:27
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner December 18, 2023 08:27
sangeethababu9223 and others added 5 commits December 18, 2023 13:57
@sangeethababu9223
Merge branch 'main' into feat/ibmdotcom-styles-remove-react-class-2
76702e2
@m4olivei @sangeethababu9223
feat(card): use link instead of button for pictogram card (carbon-des…
1197e24 
…ign-system#11225)

Closes carbon-design-system#10960
[Jira ticket](https://jsw.ibm.com/browse/ADCMS-4074)

Alternate approach to fixing carbon-design-system#10960. Previously we had attempted a resolution that wrapped the whole card in `<a></a>`. That solution introduced regressions with accessibiltiy. It's also come to my attention that the approach is a well [known poor approach](https://css-tricks.com/block-links-are-a-pain-and-maybe-just-a-bad-idea/).

This solution takes the same approach as the Default Card component, which is to wrap the footer icon in a `<a></a>` and then absolute position a pseudo element child to make the whole card clickable still. More on [the pseudo-element  method](https://css-tricks.com/block-links-the-search-for-a-perfect-solution/#aa-method-3-the-good-ol-before-pseudo-element).

**Changed**

- Wrap the footer icon in a link for the card pictogram in the same way as the default card
- Adjustment to Storybook for Card so that the body copy is used on page load

**Removed**

- Remove the `role="button"` wrapper for pictogram card
@jkaeser @sangeethababu9223
feat(github-actions): restore workflow for publish masthead v2 alpha (c…
0654cfd 
…arbon-design-system#11249)

### Description

Re-adds workflow that allows Innovation Team to build masthead v2 alpha CDN bundles. Workflow originally authored by @jeffchew in carbon-design-system#11153.

### Changelog

**New**

- Restores masthead v2 alpha CDN bundle publishing workflow.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@sangeethababu9223
feat(ibmdotcom styles): resolve conflicts
dbff424
@sangeethababu9223
Merge branch 'main' into feat/ibmdotcom-styles-remove-react-class-2
65c047e
@sangeethababu9223 sangeethababu9223 marked this pull request as draft January 4, 2024 10:39
@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review January 8, 2024 07:28
@sangeethababu9223 sangeethababu9223 marked this pull request as draft January 11, 2024 07:59
@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review January 17, 2024 15:17
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2024 •
edited

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11218/index.html

Built with commit: 208084b21684e494b6a86a985abca443b4abd902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@carbon/ibmdotcom-styles]: remove React classes from component styles
5 participants
@sangeethababu9223 @ibmdotcom-bot @kennylam @m4olivei @jkaeser