Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui shell): header and side navigation issue in small screens #11184

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix(ui shell): header and side navigation issue in small screens #11184

wants to merge 12 commits into from

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #11097

Description

Header navigation not showing in mobile menu, when there is both side and header navigation. Issue was related to documentation.

Changelog

Changed

  • Updated documentation by adding "cds-header-side-nav-items" component under "cds-side-nav-items".
  • Header Menu style updated to hide the menu items from showing in left side navigation

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner December 4, 2023 06:41
@sangeethababu9223 sangeethababu9223 added bug Something isn't working documentation Improvements or additions to documentation dev Needs some dev work package: carbon web components labels Dec 4, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 4, 2023 •
edited

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11184/index.html

Built with commit: b406177fde088ddb630d6f89a1a4fb0e07daab6c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 4, 2023 •
edited

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11184/index.html

Built with commit: b406177fde088ddb630d6f89a1a4fb0e07daab6c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 4, 2023 •
edited

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11184/index.html

Built with commit: b406177fde088ddb630d6f89a1a4fb0e07daab6c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 23, 2024 •
edited

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11184/index.html

Built with commit: b406177fde088ddb630d6f89a1a4fb0e07daab6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working dev Needs some dev work documentation Improvements or additions to documentation package: carbon web components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Shell wrong behavior - Web Components. v2 latest
2 participants
@sangeethababu9223 @ibmdotcom-bot