fix(cv-combo-box): accessibility violations #1426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnixon
requested changes
Jun 20, 2023
There was a problem hiding this comment.
This looks good to me. It matches what in react storybook
Do you have a before & after screenshot of the accessibility violations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #
## What did you do?
Fix accessibility violation: nested-interactive
caused by using a listbox role on a div with two buttons
this fix inspired by the same component in the react carbon lib
https://react.carbondesignsystem.com/?path=/story/components-combobox--default
## Why did you do it?
How have you tested it?
Were docs updated if needed?