Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2724- Fix of close method invokation in ActionableNotification close… #2727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nipun005
Copy link

@nipun005 nipun005 commented Oct 27, 2023

… button action

Closes #2724

When the user will click on close button of ActionableNotification , then the function was not invoked which user defined in html file against close method.
After this Fix- The function will be invoked.

Changelog

New

The close function will be invoked on clicking of close button of ActionableNotification.

@nipun005 nipun005 requested a review from a team as a code owner October 27, 2023 16:35
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 370d6ec
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/653be6e7ed734d000884cbba
😎 Deploy Preview https://deploy-preview-2727--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@placzkowskim
Copy link

placzkowskim commented Oct 28, 2023

Hi @nipun005 ,
I think it is not valid solution, ActionableNotification extends BaseNotification where
@Output() close: EventEmitter<any> = new EventEmitter(); is defined.
In my Issue I described that 'My onNotificationClose() method is beeing properly invoked on 'x' click.. The issue is that notification is not dissapearing on 'x' click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActionableNotification close button action.
2 participants