New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): add missing properties to AxisOptions interface #1432
fix(core): add missing properties to AxisOptions interface #1432
Conversation
/** | ||
* should be set to `true` for the | ||
* left axis to be the primary axis | ||
*/ | ||
main?: boolean; | ||
/** | ||
* used to map data on the secondary axis | ||
*/ | ||
correspondingDatasets?: Array<string>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @metonym, we should probably find a way to have this only affect combo charts, since they mostly wouldn't apply to others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- created a
ComboChartAxisOptions
interface - updated
ComboChartOption.axes
to useComboChartAxisOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8891c22
to
8b492e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing! thanks Eric for the quick update 🙂
Fixes #1413
The
AxisOptions
interface is missingmain
andcorrespondingDatasets
properties to support dual-axes charts.Updates
Demo screenshot or recording
Review checklist (for reviewers only)