feat(core): Pass treemap tile data to getFillColor
#1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-cloudnatix
requested review from
theiliad,
Akshat55 and
a team
as code owners
andre-cloudnatix
requested review from
zvonimirfras and
Donisius
and removed request for
a team
andre-cloudnatix
changed the title
getFillColorgetFillColor
andre-cloudnatix
commented
Apr 7, 2022
| @@ -167,8 +167,7 @@ export class Treemap extends Component { | |||
| .attr('width', (d) => d.x1 - d.x0) | |||
| .attr('height', (d) => d.y1 - d.y0) | |||
| .style('fill', (d) => { | |||
| while (d.depth > 1) d = d.parent; | |||
There was a problem hiding this comment.
It seems the treemap does not support nested data structures, so this while loop seems safe to delete.
andre-cloudnatix
changed the title
getFillColorgetFillColor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
getFillColor-function for the treemap component (which is useful for creating divergent tree maps)If you like to try it out yourself you should make a build and try the code in the sandbox below:
https://codesandbox.io/s/carbon-treechart-getfillcolor-for-color-per-tile-fr4f10
Demo screenshot or recording
Value in console is the third argument that is passed to
getFillColorScreen.Recording.2022-04-07.at.10.52.42.mov
Review checklist (for reviewers only)