Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(core): add demo to change toolbar overflow menu control text for defined types #1296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(core): add demo to change toolbar overflow menu control text for defined types #1296

wants to merge 1 commit into from
+28 −0

Conversation

Akshat55
Copy link
Collaborator

@Akshat55 Akshat55 commented Feb 1, 2022

Updates

  • Added demo to show users how to overwrite the export titles (text).
  • This method can also be used to change text during language changes in applications (Translations/localization)
    • Keep in mind, the library user is responsible for determining the language changes

Demo screenshot or recording

image

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@Akshat55 Akshat55 requested review from theiliad and a team as code owners February 1, 2022 20:29
@Akshat55 Akshat55 requested review from zvonimirfras and Donisius and removed request for a team February 1, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad Awaiting requested review from theiliad theiliad is a code owner

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras zvonimirfras is a code owner automatically assigned from carbon-design-system/carbon-charts

@Donisius Donisius Awaiting requested review from Donisius Donisius is a code owner automatically assigned from carbon-design-system/carbon-charts

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Akshat55