#622@patch: Fix Element.matches failing when using non-matching desce… #625
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ching descendant selector on element detached from document.
IGx89
commented
Oct 18, 2022
| }; | ||
| } | ||
|
|
||
| if (!currentNode.parentElement || (targetNode === currentNode && !result.matches)) { |
There was a problem hiding this comment.
Refactored slightly to always verify parentElement is not null, making it pass null checks in case you ever turn on strictNullChecks.
There was a problem hiding this comment.
Yes that would be good to turn on 🙂
capricorn86
approved these changes
Oct 18, 2022
IGx89
deleted the
task/622-fix-matches-non-matching-descendant-selector
branch
|
I was using TableCell from materialUI-core and experiencing this issue until your fix. Thanks for the quick fix and release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndant selector on element detached from document.
Fixes second issue reported under #622