#582@patch: Window.fetch handles URL and Request objects. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capricorn86
requested changes
Oct 17, 2022
| @@ -1,5 +1,8 @@ | |||
| import IHeaders from './IHeaders'; | |||
| import IBody from './IBody'; | |||
| import URL from './../location/URL'; | |||
|
|
|||
| export type RequestInfo = IRequest | string | URL; | |||
There was a problem hiding this comment.
I would prefer to put the type as an interface with "I" as prefix in its own file, so that it is easy to find it (e.g. by doing ctrl + p and search for it).
There was a problem hiding this comment.
ok, just that I understand you right, I will create a new file IRequestInfo.ts with only these two lines:
import URL from './../location/URL';
export type IRequestInfo = IRequest | string | URL;But RequestInfo is not really a Interface isn't it? It can be a string or URL which are no Interfaces
|
Hi @stefanhoelzl! 🙂 We have fixed this now as part of this PR which has been merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.fetchcan now handleRequestandURLobjects as first parameter.See https://developer.mozilla.org/en-US/docs/Web/API/fetch#parameters