Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#622@patch: Fix Element.matches failing when using non-matching desce… #623

Conversation

IGx89
Copy link
Contributor

@IGx89 IGx89 commented Oct 15, 2022

…ndant selector on element attached to document.

Fixes #622. Was calling selector.match on the Document, which isn't an Element.

…ching descendant selector on element attached to document.
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🌟

@capricorn86 capricorn86 merged commit a6407b7 into capricorn86:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element.matches fails when using non-matching descendant selector on element attached to document
2 participants