New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#475@minor: Adds support for HTMLMediaElement. #535
Conversation
although those tags extend from Of course this is my personal advice, perhaps repo owner's advice is more valuable. |
Hi @Mas0nShi ,
|
yes, it's my advices, we can add HTMLMediaElement and HTMLVideoElement though identical or incomplete. |
done |
ddc215a
to
e211de5
Compare
de18f41
to
9803545
Compare
Hi @rudywaltz and @Mas0nShi ! 🙂 Sorry for not looking into this earlier. It has been a lot going on in my private and work life. I have managed to get the PR build to work and it seems like this PR is failing to build. I can merge this when the build is successful. |
Hi @Mas0nShi ! 🙂 Sorry for not looking into this earlier. It has been a lot going on in my private and work life. I have managed to get the PR build to work and it seems like this PR is failing to build. I can merge this when the build is successful. |
cec0b8e
to
b21da44
Compare
Hi @capricorn86 , thank you for taking care of this repo. Can I ask some hint where is the missing part. I see the error locally as well
but I have no idea where is the missing part. I try to follow the DialogElement implementation and I don't find any place where the Audio is missing ): |
@rudywaltz I found the error. In It's failing because the interface is using the name |
It seems like we got a small merge conflict as well. When that and the property is fixed I will merge it 🙂 |
2c0c67a
to
443e5e7
Compare
…age that makes it impossible to register Happy DOM globally again after unregistering it.
With this last "config resolve commit" the history is not too nice, if you need I can try rebasing and creating a new PR with more flat commit history. |
@rudywaltz I made a squash 🙂 |
Resolves #484
Resolves #475
It's a very basic implementation mostly covering the API (at least what is common between audio and video and widely supported in browsers)
timeRanges
implementation coming from jsdom as the comment mentioned.I try to implement some basic logic but mostly is missing, I hope this can be good enough as a first step.
References:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement
https://html.spec.whatwg.org/#htmlmediaelement
https://github.com/jsdom/jsdom
p.s.: should I need to add HTMLAudioElement and HTMLVideoELement to window.ts and index.ts or the changes is the packages/happy-dom/src/config/ElementTag.ts in enough for use?