Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add fromRect method #1408

Merged
merged 7 commits into from May 6, 2024
Merged

feat: Add fromRect method #1408

merged 7 commits into from May 6, 2024

Conversation

btea
Copy link
Contributor

@btea btea commented Apr 14, 2024

No description provided.

@btea btea requested a review from capricorn86 as a code owner April 14, 2024 03:04
capricorn86
capricorn86 approved these changes May 6, 2024
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @btea! 🌟

This was already implemented in #1402. However, I have added the additional test that you added.

@capricorn86 capricorn86 merged commit 7a5b003 into capricorn86:master May 6, 2024
2 of 3 checks passed
@btea btea deleted the feat/add-fromRect branch May 7, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@btea @capricorn86